Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest must be embedded in primary entry page #333

Closed
mattgarrish opened this issue Sep 12, 2018 · 4 comments
Closed

manifest must be embedded in primary entry page #333

mattgarrish opened this issue Sep 12, 2018 · 4 comments

Comments

@mattgarrish
Copy link
Member

As discussed in PR #331, there are currently no restrictions on what resource can contain the embedded manifest. Proposal is to restrict to the primary entry page (must provide a link to the manifest or must embed the manifest).

@dauwhe
Copy link
Contributor

dauwhe commented Sep 12, 2018

Yes. Absolutely!

@GarthConboy
Copy link
Contributor

And semi-related... how does a WP-aware RS/AU know that a non-primary-entry-page resource is part of a WP. E.g., a link to "chapter 27" -- how does such a RS/UA know to jump into "WP mode" following that link? And, yea, all the "part of multiple WPs" issues arise too.

@BigBlueHat
Copy link
Member

If we want any SEO value from the contents of the manifest, it MUST be embedded in the entry page.

@mattgarrish
Copy link
Member Author

This is closed with #335.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants