Remove @ from keywords
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgarrish
approved these changes
Sep 11, 2018
|
Based on the discussion on #312 this PR does what we have decided. However, we may want to wait a bit to see if the changes in the JSON schema are fine or not (@HadrienGardeur). Then again, if there is an issue, that can be taken care of later... |
schema/publication.schema.json
Outdated
| @@ -223,4 +223,4 @@ | |||
| } | |||
| }, | |||
| "required": ["@context", "url", "@type"] | |||
There was a problem hiding this comment.
This should be changed from @type to type as well.
|
@HadrienGardeur thanks, I missed this one. I have changed that, too. Merging and closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
@sign from the JSON-LD keywords@id,@type,@language, and@value, as agreed on a call for #312. (Not closing that issue, because there is still editorial work do to related to that issue. This meanttypeterm is now both a json schema keyword and a term in the data. I hope json schema can cope with that)I have also
rel='canonical'.Fix #324
Preview | Diff