-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the primary entry page #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sentence "If a default reading order is not provided, however, user agents will use the primary entry page as the default entry." makes me wonder: what if the reading order is provided? isn't the PEP the default entry anymore? this is the redundency of the term "(default) entry" which is the problem. Could we replace it by something like "if ..., user agents will consider that the primary entry page is the unique entry in the reading order"?
It's a fallback, so we shouldn't be talking about a "default entry" IMO. It's meant to make things easier for "single resource in the reading order" publications. |
Right, it's just trying to capture that it gets inserted when creating the canonical manifest if no reading order is specified. I've removed the default entry aspect and linked it to the canonical manifest step. |
The latest commit from @mattgarrish is in line with the text in 4.5.1:
+1 thus |
Isn't that required now? If the WP MUST have a PEP, then it has to be specified either in the resources or the default reading order, which puts it within the bounds. Would it help to add a parenthetical to this effect after the first MUST, like:
|
Where does it say that? I was looking at 3.4, and I did not see this stated. It just says it is a "resource" (in its general form), but that may mean it is part of the "links" array... So yes, I believe this should be explicitly stated. |
I modified the first paragraph of 3.4 to use MUSTs, so it now reads:
Or that's what you should be seeing if the preview isn't doing something weird. If we want it clearer, I can add a parenthetical like I mentioned above. |
@mattgarrish that is what I see indeed. And it does not say that, formally, it must be part of either the reading order or the resources array in the manifest, and that is what defines the boundaries... I think adding the parenthetical remark is actually necessary. |
I've rewritten the paragraph, as we're starting to repeat statements elsewhere in the specification. In the immediately preceding Resources section, for example, we say:
Instead of repeating that again, I've moved the definition of what the PEP is to the start and made the only MUST that it has to be in one of those lists. The address section also states that it is equivalent of the PEP, so I don't think we need to normatively say again that is the expectation. For quick reference, it's now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With comments and changes already address, LGTM. Thanks!
As far as I am concerned it is a go! |
Is it not necessary to define the primary entry page in the manifest? https://w3c.github.io/wpub/#simple-book Or is the HTML pointed to by "url" (by default "./index.html") treated as a primary entry page? |
Yes. |
To respond a little more completely (was travelling earlier), the |
This PR addresses two of the concerns raised in issue #386:
Preview | Diff