-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"display_override" field addition to the Web Manifest #530
Comments
I'm curious what led to the design of the fallback ordering. It seems a little strange for the existing |
@dbaron do you mine elaborating what you mean by recommended authoring practices (is this authoring of the manifest?), current examples (my examples, or ones given for using a manifest currently?), and processing model? |
@mgiuca might be able to provide context on why the current fallback chain was chosen. I found this bug conversation: It doesn't look like any of the problems that Matt [1] or I [2] outline are considered. It was probably too early in the development to see them. [1] w3c/manifest#856 |
By recommended authoring practices, I meant for people authoring a manifest. For example, using the example at the start of this issue, perhaps the recommended usage (given the current spec) should be: {
"display": "standalone",
"display-override": ["standalone", "minimal-ui"],
} so that it's more likely to produce the same results in implementations that do versus don't support |
I think that example should probably just be {
"display": "standalone"
} No need for the override, right? All user agents must support How do you imagine it to work if the new field was a fallback? Would that mean we are redefining the I feel like I failed to describe something here. Another way to think about |
OK, I permuted the example the wrong way. Why should it not be (given the current spec):
which seems to have the advantage that it would use This concern feels true with a number of the other examples in the explainer; it's not clear to me why these examples are the recommended ways of achieving the results, at least in the presence of some implementations that support the feature and some that don't. (I guess that's not a permanent situation, but it's one that probably matters for a while and for the period when the explainer is likely to be relevant.) |
Ah! Ok, so this is a case where I don't think I'm explaining things well enough. For the minimal-ui example:
The developer wants to use {
"display": "minimal-ui"
} A: WebApp supported, with The developer says "Hey - Browser B supports WebApps, why can't I just be
with {
"display": "standalone",
"display_override": ["minimal-ui"]
} A: WebApp supported, with In this case, now the WebApp is possible with all browsers. The other examples highlight other problems - for example, the new Tabbed mode proposal. Without
If I have some time I'll try to update the explainer with a more thorough explanation of what various browsers would do for various display settings. I'm also happy to do a quick VC here to have higher bandwidth - I might not be understanding something you're saying. |
Thanks for elaborating, Daniel. I think it's also important to note that basically every example using I think that's important to keep in mind, since we've had a lot of feedback saying "why not design it so that developers set |
Having the explainer explain that "thinking through", at least for some of the examples, would be helpful. (And making sure that the examples make sense in that context.)
This is very helpful -- and also something that would be helpful if it were in the explainer. |
Thanks - great suggestions, I'll add this info to the explainer soon. Sorry that this wasn't communicated better! |
I just updated the explainer to have more information about the context & background, as well as having more information in the use cases. Hopefully that is more helpful! :) |
Those explainer updates are helpful; thanks. The TAG discussed this just now in our teleconference (and a little in Breakout C about 36 hours ago), and we're happy closing this. We'd encourage you to continue the standardization process for this (presumably bringing it to the Web Apps WG which maintains Manifest) and to address other feedback that comes up in that process, and also to do so for the related features that you reference in the explainer. |
Thanks! |
Saluton TAG!
I'm requesting a TAG review of
display_override
.Add a new field to the web manifest, "display-override", where a developer can specify an explicit display fallback chain they would like applied.
Example of a website that wants "minimal-ui" to fall back to "standalone" (currently not possible due to the static fallback chain in the spec for
display
).Further details:
display
rather than merely an override list dmurph/display-mode#10You should also know that...
This is intended to be a minor behavioral change to the way display modes are processed & specified. This is currently blocking new display modes like tabbed & custom window overlay mode, as they cannot place themselves in the current display list without significant problems.
We'd prefer the TAG provide feedback as (please delete all but the desired option):
🐛 open issues in our GitHub repo for each point of feedback
The text was updated successfully, but these errors were encountered: