Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early Design Review: Pending Beacon API #776

Closed
mingyc opened this issue Sep 27, 2022 · 20 comments
Closed

Early Design Review: Pending Beacon API #776

mingyc opened this issue Sep 27, 2022 · 20 comments
Assignees
Labels
Progress: in progress Resolution: overtaken for example another proposal has emerged which covers the same use cases and enjoys broader support Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG Venue: WICG

Comments

@mingyc
Copy link

mingyc commented Sep 27, 2022

Wotcher TAG!

I'm requesting a TAG review of Pending API.

This is a proposal for Pending Beacon API. It is a system for sending beacons when pages are discarded, that uses a stateful API rather than having developers explicitly send beacons themselves.

Further details:

You should also know that...

[please tell us anything you think is relevant to this review]

We'd prefer the TAG provide feedback as (please delete all but the desired option):

💬 leave review feedback as a comment in this issue and @-notify @mingyc and @fergald

@mingyc mingyc added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Sep 27, 2022
@torgo torgo added this to the 2022-10-10-week milestone Sep 29, 2022
@mingyc mingyc changed the title Early Design Review: Page Unload Beacon API Early Design Review: Pending Beacon API Oct 17, 2022
@mingyc
Copy link
Author

mingyc commented Dec 8, 2022

Friendly ping on this request as it has been a while.

@maxpassion maxpassion self-assigned this Jan 17, 2023
@ylafon
Copy link
Member

ylafon commented Feb 7, 2023

Hi, @maxpassion and I reviewed this during our F2F and we have a few questions:

About the use of Get/PostPendingBeacon, why not using the method in a dictionary instead of having two instances? How about ensuring that a PostPB isn't sent twice (like if there is a crash).
Issues about crash recovery, should it be done after a network and/or location change, as it can have privacy implications? after a time limit?
Do having a pending beacon registered impact how bfcache work?

What is the point of forcing a PendingBeacon to be sent, if it is supposed to be sent at the end of the interaction, why not using fetch or a normal beacon in that case?

Why existing mechanism is not reliable and how this new proposed mechnisam solve the not reliable issue? Should the HTML unload event be fixed instead? Could this be solved at the Page Lifecycle level instead of having a new specification?

Thanks,

@ylafon ylafon added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Feb 7, 2023
@plinss plinss added this to the 2023-07-10-week milestone Jul 7, 2023
@hober
Copy link
Contributor

hober commented Jul 17, 2023

whatwg/fetch#1647

@cynthia
Copy link
Member

cynthia commented Jul 31, 2023

We're assuming deferred fetch as proposed in whatwg/fetch#1647 will supersede this, should this be closed? @mingyc @fergald

@mingyc
Copy link
Author

mingyc commented Aug 3, 2023

In that case, should deferred fetch be reviewed here (or in another new issue)?

@cynthia
Copy link
Member

cynthia commented Aug 5, 2023

For this case I might recommend a new issue.

@mingyc
Copy link
Author

mingyc commented Aug 28, 2023

Filed a Specification Review #887 as I think we have passed the early design stage.

@torgo torgo modified the milestones: 2023-09-25-week, 2023-10-09-week Oct 8, 2023
@cynthia cynthia closed this as completed Jan 23, 2024
@torgo torgo removed this from the 2024-01-23-f2f-London milestone Jan 23, 2024
@cynthia cynthia added Resolution: satisfied The TAG is satisfied with this design and removed Progress: in progress labels Jan 23, 2024
@torgo torgo added Progress: in progress Resolution: overtaken for example another proposal has emerged which covers the same use cases and enjoys broader support and removed Resolution: satisfied The TAG is satisfied with this design labels Jan 23, 2024
@martinthomson
Copy link
Contributor

See #887 for the review of FetchLater, which is the successor of this.

@torgo torgo added Resolution: overtaken for example another proposal has emerged which covers the same use cases and enjoys broader support and removed Resolution: overtaken for example another proposal has emerged which covers the same use cases and enjoys broader support labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: in progress Resolution: overtaken for example another proposal has emerged which covers the same use cases and enjoys broader support Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG Venue: WICG
Projects
None yet
Development

No branches or pull requests