Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Apply methods? #2

Closed
delaneyj opened this issue May 16, 2021 · 3 comments
Closed

adding Apply methods? #2

delaneyj opened this issue May 16, 2021 · 3 comments

Comments

@delaneyj
Copy link

It appears that https://github.com/evanphx/json-patch doesn't support the patches you are generating. I really like the terse results of your patches and have validated that they are valid. Given you are already parsing and looking for deltas, would it be possible to make some Apply and Revert functions in addition to patch generation?

@wI2L
Copy link
Owner

wI2L commented May 16, 2021

@delaneyj
I'm surprised to hear that the evanphx/json-patch package doesn't work with some patch generated by jsondiff. Could you please share an example ?

@delaneyj
Copy link
Author

evanphx/json-patch#142

Looks like root access via a "" json pointer errors out. I also looked at writing my own using gabs but it has the same issue but a fix is incoming there.

@wI2L
Copy link
Owner

wI2L commented May 25, 2021

@delaneyj I think this issue is better fixed in evanphx/json-patch. I have no plans to extend the library to add support for JSON patch application, since the before-mentioned package works pretty well.

@wI2L wI2L closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants