Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to store in memory all layers #105

Closed
ChrisCinelli opened this issue Nov 29, 2018 · 2 comments · Fixed by #108
Closed

Prevent to store in memory all layers #105

ChrisCinelli opened this issue Nov 29, 2018 · 2 comments · Fixed by #108

Comments

@ChrisCinelli
Copy link
Contributor

On my machine, for large images, the RAM is more a constraint than the CPU.

The whole layers are copied in memory. I tried to fixing this while I was working on #103 .
This is what I did : ChrisCinelli@8e4ea7c#diff-da07f373046a0a24e67b18699dc15a70
but I had to remove the concurrency since the reader is not thread safe.

By the way, I also think you have a problem with accessing to the layerMap in processLayerTar at the moment.

@ChrisCinelli
Copy link
Contributor Author

@wagoodman
Copy link
Owner

wagoodman commented Nov 29, 2018

Yeah, this is something like what I had initially without concurrency. I feel that enough bad side effects have been discovered to ditch concurrency (between memory usage and the concurrent hash access) . I'll pull in the changes from your branch in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants