Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the gocui layout into a controllable abstraction #178

Closed
wagoodman opened this issue Mar 25, 2019 · 1 comment
Closed

Refactor the gocui layout into a controllable abstraction #178

wagoodman opened this issue Mar 25, 2019 · 1 comment

Comments

@wagoodman
Copy link
Owner

wagoodman commented Mar 25, 2019

Currently the layout function (

dive/ui/ui.go

Line 186 in 993be8d

func layout(g *gocui.Gui) error {
) is mostly hardcoded and does not allow for dynamically changing the layout easily (or swapping out the layout entirely). This will be useful when adapting the UI for #52.

Additionally, while refactoring, errors during gocui actions should be reported up to the UI object and log accordingly. This will make problems like seen in #225 more visible.

@wagoodman wagoodman added this to the v0.9.0 milestone Sep 6, 2019
@wagoodman
Copy link
Owner Author

addressed in #256

@wagoodman wagoodman removed this from the Packaging milestone Dec 17, 2019
@wagoodman wagoodman moved this to Done in UI Enhancements Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant