Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Arrow keys to collapse and expand directories #46

Closed
DomHudson opened this issue Oct 28, 2018 · 6 comments
Closed

Feature Request: Arrow keys to collapse and expand directories #46

DomHudson opened this issue Oct 28, 2018 · 6 comments
Milestone

Comments

@DomHudson
Copy link

This is a very cool project - I appreciate the work. I've just got a minor feature request/suggestion. To me it feels quite natural to close directories with the left arrow key and open them with the right.
What do you think?

@wagoodman wagoodman added this to the v0.1.0 milestone Oct 29, 2018
@wagoodman
Copy link
Owner

Thanks! I agree with your idea for the right arrow, after #43 was merged (v0.0.8) I was thinking the same thing. Essentially the right key should traverse deeper into the file tree, expanding when necessary.

Though I feel like the left key should leave directories expanded as they are and simply navigate back up to the parent directory.

@wagoodman wagoodman modified the milestones: v0.1.0, v0.0.8 Oct 29, 2018
@akshaychhajed
Copy link
Contributor

Just to maintain symmetry 😉, I will try.

@DomHudson
Copy link
Author

One option would be to have the left key close the directory if your cursor is currently on a directory, otherwise go back to the parent folder. This way pressing left once will jump to the parent, pressing again would close it and repeat. You could keep pressing left and it would iteratively jump higher and close the directories.

@TJM
Copy link

TJM commented Oct 29, 2018

I was thinking something like "shift+left-arrow" if you want to navigate left, but leave it expanded?

@wagoodman
Copy link
Owner

wagoodman commented Oct 30, 2018

@DomHudson , your suggestion is tempting, but I feel that a file explorer expanding a dir on navigation makes sense, but closing on navigation is an extra mental leap. That is, usually the user is trying to see more content more quickly, not hide it more quickly.

However, I agree that there is room for improvement to make the file explorer more intuitive and in general add more user-friendly features (such as a simple search to jump a user to a matching file/path).

@DomHudson
Copy link
Author

Thank you very much for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants