Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main nav made scrollable #178

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

PaarthAgarwal
Copy link
Member

Fixes #176.

@tbrlpld
Copy link
Collaborator

tbrlpld commented May 27, 2022

Looks good to me! Thanks for the quick fix @PaarthAgarwal!

I think there might be an opportunity to restructure the overall layout a little to make this behaviour feel a bit more "solid", but this is a great fix.

@tbrlpld tbrlpld merged commit 32aad91 into wagtail:main May 27, 2022
@PaarthAgarwal
Copy link
Member Author

Glad you liked it!

@PaarthAgarwal
Copy link
Member Author

Does it need a changelog entry?

@lb-
Copy link
Member

lb- commented May 28, 2022

Does it need a changelog entry?

I think the existing changelog entry covers it, this is just a refinement on the move to sticky TOC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll issues on long table of content
3 participants