in notify.c use luaL_checkstack like we did in signal.c, because the …

…caller could easily cause us to push more than LUA_MINSTACK values onto the stack
wahern · Aug 11, 2016 · 4abc3ac · 4abc3ac
1 parent b563b87
commit 4abc3ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/notify.c b/src/notify.c
@@ -191,6 +191,7 @@ static int ln_strflag(lua_State *L) {
 		flags &= ~flag;
 
 		if ((name = notify_strflag(flag))) {
+			luaL_checkstack(L, 1, "too many results");
 			lua_pushstring(L, name);
 			count++;
 		}

diff --git a/src/signal.c b/src/signal.c
@@ -428,11 +428,11 @@ static int lsl_strflag(lua_State *L) {
 		while ((flag = signal_flags(&flags))) {
 			const char *txt;
 
-			if (!(txt = signal_strflag(flag)))
-				continue;
-			luaL_checkstack(L, 1, "too many arguments");
-			lua_pushstring(L, txt);
-			count++;
+			if ((txt = signal_strflag(flag))) {
+				luaL_checkstack(L, 1, "too many results");
+				lua_pushstring(L, txt);
+				count++;
+			}
 		}
 	}