Fix grammatical error in status bar tooltip #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmonslay
commented
Jul 17, 2021
| @@ -467,7 +467,7 @@ export class WakaTime { | |||
| if (code == 0) { | |||
| if (output && this.showStatusBar && this.showCodingActivity) { | |||
| this.statusBar.text = `$(clock) ${output}`; | |||
| this.statusBar.tooltip = `WakaTime: You coded ${output.trim()} today.`; | |||
| this.statusBar.tooltip = `WakaTime: Today you have spent ${output.trim()}.`; | |||
There was a problem hiding this comment.
Suggested change
| this.statusBar.tooltip = `WakaTime: Today you have spent ${output.trim()}.`; | |
| this.statusBar.tooltip = `WakaTime: You have spent ${output.trim()} today.`; |
Might be better as it matches the original tooltip closer.
alanhamlett
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tooltip in the status bar will start with "You coded", resulting in a grammatical error when the output is added which this PR aims to fix.
For example, the message
will be changed to
Screenshot of current tooltip: