Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use current timestamp when not provided in relay rest api #926

Closed
chaitanyaprem opened this issue Nov 24, 2023 · 1 comment · Fixed by #940
Closed

feat: use current timestamp when not provided in relay rest api #926

chaitanyaprem opened this issue Nov 24, 2023 · 1 comment · Fixed by #940
Assignees
Labels
enhancement New feature or request

Comments

@chaitanyaprem
Copy link
Collaborator

Problem

When publishing a message via the REST API without setting a timestamp, default to the current one instead of 0 when RLN is enabled.

curl -X POST "http://127.0.0.1:8645/relay/v1/auto/messages"
-H "content-type: application/json"
-d '{"payload":"XQ==","contentTopic":"/my-app/2/chatroom-1/proto"}

Note: Also need to make this mandatory in Relay publish API if RLN is enabled, else need to set it to currentTimestamp.

@chaitanyaprem chaitanyaprem added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Nov 24, 2023
@chaitanyaprem chaitanyaprem changed the title feat: use current timestamp when unset in rest api feat: use current timestamp when not provided in relay rest api Nov 28, 2023
@chaitanyaprem chaitanyaprem moved this to Priority in Waku Nov 28, 2023
@chaitanyaprem chaitanyaprem self-assigned this Nov 28, 2023
@chaitanyaprem chaitanyaprem moved this from Priority to Code Review / QA in Waku Nov 30, 2023
@chaitanyaprem
Copy link
Collaborator Author

Weekly Update

  • achieved: return error in relay API when message gossipsub threshold is crossed, fill messageTimestamp if RLN is enalbed and not set in WakuMessage, improve errors returned for filter unsubscribe APIs

@chaitanyaprem chaitanyaprem removed the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Dec 1, 2023
@chair28980 chair28980 added the enhancement New feature or request label Dec 3, 2023
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants