Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve test coverage on NetConfig generation #1540

Closed
2 tasks
rymnc opened this issue Feb 7, 2023 · 1 comment · Fixed by #2091
Closed
2 tasks

chore: improve test coverage on NetConfig generation #1540

rymnc opened this issue Feb 7, 2023 · 1 comment · Fixed by #2091
Assignees
@gabrielmer
Labels
good first issue Good for newcomers test Issue related to the test suite with no expected consequence to production code

Comments

@rymnc
Copy link
Contributor

rymnc commented Feb 7, 2023

Background

In #1512, the waku node network config was abstracted out.
Test coverage on address generation is low at the moment.

Details

Tests for the network config generation to improve coverage to detect regressions.

Acceptance criteria

  • Identify common network configs
  • Tests for the same

cc: @jm-clius
@oskarth oskarth added this to Waku and Vac Research Feb 7, 2023
@jm-clius jm-clius moved this to Icebox in Waku Mar 20, 2023
@vpavlin vpavlin added the good first issue Good for newcomers label Jul 15, 2023
@gabrielmer gabrielmer self-assigned this Sep 26, 2023
@gabrielmer gabrielmer moved this from Icebox to In Progress in Waku Sep 26, 2023
@gabrielmer gabrielmer mentioned this issue Sep 28, 2023
Merged
3 tasks
@gabrielmer
Copy link
Contributor

gabrielmer commented Sep 29, 2023 •
edited
Loading

Weekly Update

  • achieved: developed the new NetConfig test suite, raised PR, received and implemented feedback and merged.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Sep 29, 2023
@fryorcraken fryorcraken added the test Issue related to the test suite with no expected consequence to production code label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielmer gabrielmer

Labels
good first issue Good for newcomers test Issue related to the test suite with no expected consequence to production code
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: adding NetConfig test suite waku-org/nwaku
4 participants
@vpavlin @rymnc @gabrielmer @fryorcraken