chore: bump nim-libp2p, nim-toml-serialization, nim-unicodedb, nim-unittest2, nim-websock, nim-zlib, & nimbus-build-system #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from b4c63f2 |
Ivansete-status
requested review from
jm-clius,
SionoiS,
NagyZoltanPeter and
gabrielmer
Ivansete-status
changed the title
SionoiS
approved these changes
Sep 21, 2023
| askNewConnectedPeers = false, | ||
| numPeersToAsk = 3, | ||
| maxQueueSize = 3, | ||
| minConfidence = 0.7) | ||
|
|
||
| proc statusAndConfidenceHandler(networkReachability: NetworkReachability, | ||
| confidence: Option[float]): | ||
| confidence: Opt[float]): |
There was a problem hiding this comment.
Whats the difference between Option[] and Opt[] ?
edit: found my own answer :P
You can use
Opt[T]as a replacement forOption=Optis an alias for
Result[T, void], meaning you can use the fullResultAPI on it:
jm-clius
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New bumping for 0.21.0. Almost done. In this case, the
nim-libp2pis updated again because the correct branch is theunstableone.nim-libp2phas themasterbranch butmasteris only updated every few months. We'll take care of that on further bumps.Changes
The next dependencies are updated:
Issue
#2041