-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize rest-api types #2121
Comments
@NagyZoltanPeter I assigned this issue to you please update if thats incorrect, thank you! |
Weekly Update
|
Block while come to decision on rest api spec changes. |
Downprio! |
This is not applicable for current code base. |
Background
While rest api nwaku implementation is segregated by endpoints they implements their own types one-by-one.
This can be misleading adds complexity by code duplication and does not reflects one rest-api for Waku node as common.
Details
Ongoing task #2120 track normalize of openapi specifications and documentation.
This task tries to address and follow up that changes.
[ ] Reorganize types into common place
[ ] Remove type duplications
[ ] Enforce common naming scheme
[ ] Easy marshalling/de-marshalling code for api types, remove duplications of code/copy-pastes
Acceptance criteria
[ ] No change in functionality
[ ] All tests are passed
[ ] Alignment with go-waku and js-waku done in case of naming changes on api level.
The text was updated successfully, but these errors were encountered: