feat: adding ext-multiaddr-only CLI flag #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
You can find the image built from this PR at Built from aec9d4d |
vpavlin
added
the
release-notes
vpavlin
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
LGTM, would like to know opinion of @alrevuelta, @Ivansete-status, @NagyZoltanPeter or anyone else:)
Discussion in https://discord.com/channels/1110799176264056863/1164492374672678922
gabrielmer
changed the title
Ivansete-status
approved these changes
Oct 24, 2023
gabrielmer
added a commit
that referenced
this pull request
Oct 26, 2023
omahs
pushed a commit
to omahs/nwaku
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
ext-multiaddr-onlyCLI flag so user can override the announced address with their addresses passed to theext-multiaddrflags. This option will allow us to set up a node behind a proxy and publish the proxy's address.Changes
ext-multiaddr-onlyCLI flagIssue
closes #1797