Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple listen and announced addresses #2148

Closed
2 tasks done
gabrielmer opened this issue Oct 23, 2023 · 2 comments · Fixed by #2203
Closed
2 tasks done

chore: decouple listen and announced addresses #2148

gabrielmer opened this issue Oct 23, 2023 · 2 comments · Fixed by #2203
Assignees
Labels
enhancement New feature or request

Comments

@gabrielmer
Copy link
Contributor

Details

Currently our "Listening on..." log does not show the addresses we are actually listening on - it prints the addresses that we announce.
This is a bit misleading and therefore, we want to separate it into two different log prints: one that includes the addresses our node is listening on and another with the addresses the node wants to announce to the outside world.

For the listen addresses, we also want to include the node's local IP, which is currently not displayed in nwaku. The local IP is logged in go-waku and it's an address where our node is reachable. Therefore, it makes sense to also include it in nwaku, both for consistency and convenience.

Acceptance criteria

  • two different logs are printed to the console, one with listen addresses and other with announced addresses
  • local IP is included in the listen addresses log
@gabrielmer
Copy link
Contributor Author

Weekly Update

  • achieved: implemented, tested and raised PR
  • next: get PR reviewed, implement feedback and merge

@fryorcraken fryorcraken added the enhancement New feature or request label Nov 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Nov 16, 2023
@gabrielmer
Copy link
Contributor Author

Weekly Update

  • achieved: got the PR reviewed, implemented feedback and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants