Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use yamux instead of mplex #2331

Closed
SionoiS opened this issue Jan 3, 2024 · 1 comment · Fixed by #2397
Closed

chore: use yamux instead of mplex #2331

SionoiS opened this issue Jan 3, 2024 · 1 comment · Fixed by #2397
Labels
enhancement New feature or request

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Jan 3, 2024

Background

The default muxer in go-libp2p is yamux, we should use the same. As seen in waku-org/go-waku#851

Details

replace this with yamux

nwaku/waku/node/waku_switch.nim

Line 93 in b0c7805

.withMplex(inTimeout, outTimeout)

@SionoiS SionoiS added the enhancement New feature or request label Jan 3, 2024
@SionoiS SionoiS mentioned this issue Jan 3, 2024
Closed
@alrevuelta
Copy link
Contributor

As reported by nim-libp2p team, yamux is ready on their side. But fyi dynamic window size is not supported.

@chair28980 chair28980 moved this to To Do in Waku Jan 16, 2024
@richard-ramos richard-ramos mentioned this issue Feb 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add yamux support waku-org/nwaku
2 participants
@SionoiS @alrevuelta