Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate Relay logic fron app.nim to waku_node.nim #2438

Closed
gabrielmer opened this issue Feb 15, 2024 · 0 comments · Fixed by #2504
Closed

chore: migrate Relay logic fron app.nim to waku_node.nim #2438

gabrielmer opened this issue Feb 15, 2024 · 0 comments · Fixed by #2504
Assignees

Comments

@gabrielmer
Copy link
Contributor

gabrielmer commented Feb 15, 2024

Background

Currently there's logic related to a Waku Node's configuration at the application level (app.nim). This shouldn't happen there in the first place, and as a consequence, there's important node configuration logic not available when we try to directly create a node.

Because of this, we have lots of duplicated code in libwaku that should belong to the Waku Node's core logic.

Acceptance criteria

A Waku Node's Relay and RLN-Relay's configuration logic should be decoupled from app.nim and belong to waku_node.nim

@gabrielmer gabrielmer self-assigned this Feb 15, 2024
@gabrielmer gabrielmer moved this to In Progress in Waku Feb 15, 2024
@gabrielmer gabrielmer mentioned this issue Feb 15, 2024
19 tasks
@gabrielmer gabrielmer changed the title chore: migrate node logic fron app.nim to waku_node.nim chore: migrate node logic fron app.nim to waku_node.nim Feb 15, 2024
@gabrielmer gabrielmer changed the title chore: migrate node logic fron app.nim to waku_node.nim chore: migrate Relay logic fron app.nim to waku_node.nim Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant