Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): use anvil instead of ganache in onchain tests #2449

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Feb 19, 2024

Description

This PR replaces ganache with anvil in the onchain rln tests in an endeavour to use better tooling with better performance.

Changes

  • Replaced ganache with anvil in test_rln_group_manager_onchain.nim
  • includes installation of anvil, with appropriate args to maintain compat

How to test

  1. source env.sh
  2. nim c --out:build/onchain_rln_test -r -d:chronicles_log_level=DEBUG -d:os=Darwin --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.24.0-rc.0-35-g50308e" -d:release --passL:librln_v0.3.4.a --passL:-lm tests/waku_rln_relay/test_rln_group_manager_onchain.nim

@rymnc rymnc self-assigned this Feb 19, 2024
@rymnc rymnc added the E:RLN on mainnet see https://github.com/waku-org/pm/issues/98 for details label Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2449

Built from c3d4ff9

@rymnc rymnc force-pushed the replace-ganache-with-anvil branch 6 times, most recently from 146671d to 5635ddf Compare February 21, 2024 15:37
@rymnc rymnc force-pushed the replace-ganache-with-anvil branch from cb1c0e8 to 74f3ce0 Compare February 21, 2024 16:09
@rymnc rymnc marked this pull request as ready for review February 21, 2024 16:09
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rymnc rymnc requested review from alrevuelta and stubbsta February 22, 2024 10:23
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rymnc rymnc merged commit f6332ac into master Feb 22, 2024
10 checks passed
@rymnc rymnc deleted the replace-ganache-with-anvil branch February 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:RLN on mainnet see https://github.com/waku-org/pm/issues/98 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants