Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping nim-libp2p after yamux timeout fix #2468

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Feb 22, 2024

Description

Bumping nim-libp2p after the following PR: vacp2p/nim-libp2p#1029

This will add a default timeout for yamux stale connections.

Changes

  • upgrading nim-libp2p

Test

Ran the version in waku-simulator, and connections are not growing indefinitely as they used to.
Screenshot 2024-02-22 at 14 47 08

@gabrielmer gabrielmer self-assigned this Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2468

Built from ae56165

@gabrielmer gabrielmer marked this pull request as ready for review February 22, 2024 12:50
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@gabrielmer gabrielmer merged commit 216531b into master Feb 22, 2024
10 checks passed
@gabrielmer gabrielmer deleted the chore-bumping-libp2p-for-yamux-timeout-fix branch February 22, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants