fix(waku_archive): only allow a single instance to execute migrations #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
gabrielmer,
NagyZoltanPeter and
Ivansete-status
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
richard-ramos
added
the
release-notes
|
You can find the image built from this PR at Built from 5d20b65 |
|
You can find the image built from this PR at Built from 5d20b65 |
Ivansete-status
approved these changes
May 29, 2024
Comment on lines
860
to
870
| let lockedRes = await s.getStr( | ||
| fmt""" | ||
| SELECT pg_try_advisory_lock({lockId}) | ||
| """ | ||
| ) | ||
| if lockedRes.isErr(): | ||
| return err("error acquiring a lock: " & $lockedRes.error) | ||
|
|
||
| if lockedRes.value == "f": | ||
| return err("another waku instance is currently executing a migration") |
There was a problem hiding this comment.
I think it could be a little bit more concise with the valueOr approach ( notice that we also use isOkOr for Result[void, ...] )
Suggested change
| let lockedRes = await s.getStr( | |
| fmt""" | |
| SELECT pg_try_advisory_lock({lockId}) | |
| """ | |
| ) | |
| if lockedRes.isErr(): | |
| return err("error acquiring a lock: " & $lockedRes.error) | |
| if lockedRes.value == "f": | |
| return err("another waku instance is currently executing a migration") | |
| let locked = (await s.getStr( | |
| fmt""" | |
| SELECT pg_try_advisory_lock({lockId}) | |
| """ | |
| )).valueOr: | |
| return err("error acquiring a lock: " & $error) | |
| if locked == "f": | |
| return err("another waku instance is currently executing a migration") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses an advisory lock which acts as a mutex for the postgresql migrations.
This lock will be acquired before any migration is executed. If it's not possible to acquire, the instance will fail to start with these errors:
Once the migration process is done, the lock will be released.
This is required for scenarios in which a postgresql database is used by more than one node (like in status).
cc: @jakubgs
Issue
closes #2726