chore: postgres_driver - acquire/release advisory lock when creating partitions #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 586125d |
|
You can find the image built from this PR at Built from 586125d |
Ivansete-status
requested review from
gabrielmer,
SionoiS,
richard-ramos and
darshankabariya
richard-ramos
approved these changes
Jun 6, 2024
SionoiS
approved these changes
Jun 7, 2024
darshankabariya
pushed a commit
that referenced
this pull request
Jun 9, 2024
rymnc
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional protection, in the shape of an advisory lock, when adding new partitions to the database.
This is interesting from the PoV of multiple nodes accessing the same database.
Issue
Not evidence that this PR will fix the following issue but it will help
#2783