-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: logging received message info via onValidated observer #2973
Conversation
You can find the image built from this PR at
Built from c3828f3 |
To add a bit of context regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gorgeous one! Thanks so much for it! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Description
Logging information related to received messages by using one of the new
onValidated
nim-libp2p
observers. This is improves our current approach of logging via thetraceHandler
, which does not provide information on who sent the message a node received.Changes
onValidated
logger observertraceHandler
initRelayMetricObserver
toinitRelayObservers
Notice that a "message received" log were added to the REST endpoints that publish messages. This is per DST's request, so they can easily tag the node that published a message to the network as a node that has seen the message.
CC @AlbertoSoutullo
Example