Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update external_config.nim #3004

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

Ivansete-status
Copy link
Collaborator

remove unused external parameter rest-private

remove unused setting
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3004

Built from f2d4674

@Ivansete-status Ivansete-status marked this pull request as ready for review August 29, 2024 12:21
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ivansete-status Ivansete-status merged commit fd84363 into master Aug 29, 2024
10 of 12 checks passed
@Ivansete-status Ivansete-status deleted the rm-unused-setting branch August 29, 2024 15:54
Ivansete-status added a commit to status-im/infra-role-nim-waku that referenced this pull request Sep 18, 2024
This is needed because nwaku no longer support this parameter.
See waku-org/nwaku#3004

Signed-off-by: Ivan Folgueira Bande <ivansete@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants