Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Node setup complete even --store-message-db-url is wrong #3018

Open
AlbertoSoutullo opened this issue Sep 4, 2024 · 0 comments
Open
Labels
bug Something isn't working effort/hours Estimated to be completed in a few hours

Comments

@AlbertoSoutullo
Copy link

Problem

nWaku completes the setup even flag --store-message-db-url is set up wrong.

To reproduce

Assuming a correct node setup, change the --store-message-db-url from a correct one like
"postgres://postgres:wakupassword@127.0.0.1:5432/postgres"
to
"postgresql://postgres:wakupassword@127.0.0.1:5432/postgres"

Expected behavior

The node should fail the setup, as the url is not existent.

nwaku version/commit hash

v0.32.0-rc.2

Additional context

Maybe is something related to how you handle the URL in the parsing of the flags, this should be easy to check.
What worries me a little bit more is even at startup if the flag value is not checked correctly, how nWaku is not crashing or logging errors afterwards, when it is supposed to have --store=true and should be archiving messages. Because in my case, the node was working correctly, but it was not saving messages in the DB.

CC: thx to @Ivansete-status for the help

@AlbertoSoutullo AlbertoSoutullo added the bug Something isn't working label Sep 4, 2024
@Ivansete-status Ivansete-status added the effort/hours Estimated to be completed in a few hours label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/hours Estimated to be completed in a few hours
Projects
Status: To Do
Development

No branches or pull requests

2 participants