Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store in status-go through nwaku #3053

Closed
Ivansete-status opened this issue Sep 23, 2024 · 3 comments
Closed

chore: store in status-go through nwaku #3053

Ivansete-status opened this issue Sep 23, 2024 · 3 comments
Assignees
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@Ivansete-status
Copy link
Collaborator

Description

status-go should support store through nwaku

To validate that, we need the TestBasicWakuV2 to work properly. We will consider this as achieved when the store part of that test works well.

https://github.com/status-im/status-go/blob/94dc345d8ef5fb95fd855a665b1d32f3b0e32008/wakuv2/waku_test.go#L180

@Ivansete-status Ivansete-status moved this to To Do in Waku Sep 23, 2024
@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Sep 23, 2024
@Ivansete-status Ivansete-status moved this from To Do to In Progress in Waku Oct 7, 2024
@richard-ramos
Copy link
Member

Requires this: waku-org/go-waku#1239
API code was highly coupled to go-waku. Ended up doing a refactor so I can proceed to properly call store from status-go/nwaku

@richard-ramos
Copy link
Member

The following PRs were created as part of this task:

This PR could block getting some of the prev PRs merged: status-im/status-go#5857 (It's been reviewed and observations/suggestions implemented and fixed, it's only missing approvals)

@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Archived in project
Development

No branches or pull requests

2 participants