We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When message validation fails, the error metric is updated, but no error is logged or returned to the calling function. See https://github.com/waku-org/nwaku/blob/c5a825e206c1cb3e6e0cf8c01410527804cb76c4/waku/waku_archive/archive.nim#L85C1-L90C11
Without the logging it is unclear that archiving doesn't occur at all.
The error should be logged, TRACE level should be sufficient. An error should be returned.
The text was updated successfully, but these errors were encountered:
SionoiS
No branches or pull requests
Background
When message validation fails, the error metric is updated, but no error is logged or returned to the calling function. See https://github.com/waku-org/nwaku/blob/c5a825e206c1cb3e6e0cf8c01410527804cb76c4/waku/waku_archive/archive.nim#L85C1-L90C11
Details
Without the logging it is unclear that archiving doesn't occur at all.
Acceptance criteria
The error should be logged, TRACE level should be sufficient. An error should be returned.
The text was updated successfully, but these errors were encountered: