New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log message validate error and return error #3132

Open

stubbsta opened this issue Oct 21, 2024 · 0 comments

Assignees

stubbsta commented Oct 21, 2024

Background

When message validation fails, the error metric is updated, but no error is logged or returned to the calling function. See https://github.com/waku-org/nwaku/blob/c5a825e206c1cb3e6e0cf8c01410527804cb76c4/waku/waku_archive/archive.nim#L85C1-L90C11

Details

Without the logging it is unclear that archiving doesn't occur at all.

Acceptance criteria

The error should be logged, TRACE level should be sufficient. An error should be returned.

SionoiS self-assigned this

SionoiS mentioned this issue

fix: add log and archive message ingress for sync #3133

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment