-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report a cluster as ready to work until node connection protocol has completed #1771
Conversation
There are two tests failing, The last 5 lines of the
The full stdout from the |
Ok I think I understand that error. I'll fix that tomorrow morning. Thanks. |
Previous to this commit, we were reporting ready to work at a boundary as soon as the TCP connection was established. Since we are not actually ready to work until all boundary connect protocol messages have been received, this changes that.
faf5eec
to
7ddfcf0
Compare
@slfritchie That error was because I was overreaching in my initial attempt. I've scaled it back to just what we need and tests are passing now. |
@SeanTAllen This makes it so that we now wait for the boundary connect protocol process to complete before we say we're ready to work. |
@jtfmumm i updated the title |
@SeanTAllen Ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works well: it doesn't have any transient failures that I can see in a few hundred attempts. @SeanTAllen any additional review?
@slfritchie nope. i merged. |
Previous to this commit, we were reporting ready to work at
a boundary as soon as the TCP connection was established.
Since we are not actually ready to work until all boundary
connect protocol messages have been received, this changes that.
Closes #1763