Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a better test for the array_is_pmf question #52

Open
charlesfrye opened this issue Jul 2, 2021 · 0 comments
Open

Make a better test for the array_is_pmf question #52

charlesfrye opened this issue Jul 2, 2021 · 0 comments
Assignees
@charlesfrye
Labels
math4ml Math for Machine Learning course materials

Comments

@charlesfrye
Copy link
Contributor

Right now, doesn't appropriately test whether there are values above 1 or below 0 because the examples don't add up to 1, which is what most folks test for.

np.array([-1, 2]) and/or np.array([-0.5, 1.1, 0.2, 0.2]) would do it.
@charlesfrye charlesfrye self-assigned this Jul 2, 2021
@charlesfrye charlesfrye added the math4ml Math for Machine Learning course materials label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesfrye charlesfrye

Labels
math4ml Math for Machine Learning course materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charlesfrye