feat: Add module for Secure Storage Connector #52
+197
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elainaRenee
commented
Feb 15, 2023
| @@ -18,7 +18,7 @@ variable "cluster_version" { | |||
| type = string | |||
| default = "1.21" | |||
| } | |||
|
|
|||
elainaRenee
commented
Feb 15, 2023
| @@ -96,7 +96,7 @@ module "aurora" { | |||
| instance_class = var.instance_class | |||
| instances = { 1 = {} } | |||
|
|
|||
| autoscaling_enabled = false | |||
| autoscaling_enabled = false | |||
| @@ -0,0 +1,69 @@ | |||
| # Weights & Biases Secure Storage Connector Module | |||
There was a problem hiding this comment.
Is this meant to replace the BYOB example?
Maybe we should update that example to point at this implementation?
There was a problem hiding this comment.
yeah, they are pretty much the same, but you need to grant access to a different AWS account. I will update the BYOB example in a follow up.
jsbroks
approved these changes
Feb 27, 2023
Comment on lines
1
to
7
| output "bucket_name" { | ||
| value = module.file_storage.bucket_name | ||
| } | ||
|
|
||
| output "bucket_arn" { | ||
| value = module.file_storage.bucket_arn | ||
| } |
There was a problem hiding this comment.
I've starting perforing this approach, but up to you!
Suggested change
| output "bucket_name" { | |
| value = module.file_storage.bucket_name | |
| } | |
| output "bucket_arn" { | |
| value = module.file_storage.bucket_arn | |
| } | |
| output "bucket" { | |
| value = module.file_storage | |
| } |
Comment on lines
9
to
11
| output "bucket_kms_key_arn" { | ||
| value = var.create_kms_key ? aws_kms_key.key[0].arn : null | ||
| } |
There was a problem hiding this comment.
same idea here, return the entire object
jsbroks
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [1.11.0](v1.10.5...v1.11.0) (2023-02-28) ### Features * Add module for Secure Storage Connector ([#52](#52)) ([8f07c99](8f07c99))
|
This PR is included in version 1.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.