-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black screen when closing mobile screen and reopening #101
Comments
trying the #98 (comment) i always get crashes using local version
|
it's weird, i can't reproduce the crash. can I test your apk? |
testing with example doesnt crash i am confused, i think i will need to try again, but cant do it right now |
i think will leave this open until the lifecycle stuff released in flutter and then migrate to it and use surface producer only instead of the current workaround correct? so its blocked by: flutter/flutter#148417 |
current code is ok |
current code will result of a black screen on impeller when screen goes off, so the life cycle stuff needs to be handled, so the black screen issue is still happens on impeller |
wait for official solution. current code is the best we can do. |
yes i dont mind that but keeping issue open will be a reminder to know that, the issue is blocked by flutter and when they fix it we will too? dont you think just so it doesnt get forgotten or people misunderstand that its is fixed fully |
I was wrong. If a surface destroyed then a new one is recreated(and rotated), they are different surfaces, but their texture id can be the same, so it's easy to fix the issue if the callback api is ready. |
I see flutter is going to recreate player object and restart playback, it's unnecessary and can be slow, maybe it's exoplayer's limitation. Mdk supports recreating renderer with a different surface, the result is frame accurate and fast |
I agree that restarting playback is not efficient, glad that mdk got it handled better |
the pr has been merged i think now this can be fixed |
try impeller branch. I'm wondering how can the code support 3.24 and old versions |
I saw this problem on flutter repo for video_player and when I am migrating media_kit I guess if java has a conditional compilation that will work correctly? Something like the API version stuff? |
java does not support conditional compilation |
i guess we cant do anything, flutter released it and updated minsdk to 3.24. |
impeller branch now supports 3.24+ and lower. gradle rewrites java code when necessary |
Wow I never thought it can be handled like that, nice |
Describe the bug
when playing a video and then closing the mobile screen and reopening the video is black.
Expected behavior
it should be working
Log
info and logs can be found here #98 (comment)
The text was updated successfully, but these errors were encountered: