Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC check of TLV/MMT stream #15

Open
MMT-TLVassociation opened this issue Jun 16, 2022 · 4 comments
Open

CRC check of TLV/MMT stream #15

MMT-TLVassociation opened this issue Jun 16, 2022 · 4 comments

Comments

@MMT-TLVassociation
Copy link
Contributor

MMT-TLVassociation@c884656
(In crc.cpp, const uint8_t* is changed to uint8_t* . )

I added code to check CRC in DumpTS.

example:
DumpTS file.mmts --CID=1 --pid=0xF300 --output=e00301.hevc

If there are any CRC error in TLV/MMT stream, CRC false message is output.
I'll pull request if your are OK.

@wangf1978
Copy link
Owner

Hi, thanks for your contribution, it is ok for me, please go ahead.

@MMT-TLVassociation
Copy link
Contributor Author

Thank you.

@wangf1978
Copy link
Owner

wangf1978 commented Jun 17, 2022

Your codebase seems not to be a fork of the original source depot, I merged your changes manually, and I found some typos, and I changed it, the main change is
if (peek_msg_id == 0x8000 || 0x8002 || 0x8003 || 0x8004)// Packet_id, which includes CRC32
Changed it to
if (peek_msg_id == 0x8000 || peek_msg_id == 0x8002 || peek_msg_id == 0x8003 || peek_msg_id == 0x8004)// Packet_id, which includes CRC32

Please see commit

@MMT-TLVassociation
Copy link
Contributor Author

Yes, you are correct. Thank you for manually merging the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants