Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to allow symfony/console ^6.0? #61

Closed
steevanb opened this issue Dec 30, 2021 · 13 comments · Fixed by #75
Closed

Any plan to allow symfony/console ^6.0? #61

steevanb opened this issue Dec 30, 2021 · 13 comments · Fixed by #75

Comments

@steevanb
Copy link

Hi,

Everything is in the title ;)

@wapmorgan
Copy link
Owner

Need to test it, may be support is just one-line change without defects.
Will try to update in near future

@Axent96
Copy link
Contributor

Axent96 commented Jan 18, 2023

@wapmorgan any updates on the topic?

@Axent96
Copy link
Contributor

Axent96 commented Mar 2, 2023

@wapmorgan symfony/console v5 is today a bit old. The issue block to use your nice detector :)

@Axent96
Copy link
Contributor

Axent96 commented Mar 3, 2023

@wapmorgan here is PR #72 for the issue. I found no problem for symfony/console ^6.0

@kkmuffme
Copy link

Issue is fixed by #72, merged and released in 2.0.30

Issue can be closed

@steevanb
Copy link
Author

Not really ;)

I've tried it with Symfony 6.2, and i have this error:
Fatal error: Uncaught TypeError: Symfony\Component\Console\Output\Output::writeln(): Argument #1 ($messages) must be of type Traversable|array|string, null given, called in /composer/vendor/wapmorgan/php-deprecation-detector/src/ScanCommand.php on line 306 and defined in /composer/vendor/symfony/console/Output/Output.php:97

From this file:
https://github.com/wapmorgan/PhpDeprecationDetector/blob/master/src/ScanCommand.php#L306

@Axent96
Copy link
Contributor

Axent96 commented Mar 16, 2023

@steevanb Do you can please check PR #74 for symfony v 6.2
@kkmuffme FYI

@szaimen
Copy link
Contributor

szaimen commented Mar 19, 2023

#75 was missing

@steevanb
Copy link
Author

@szaimen thanks, seems like it fix the bug. could you please create 2.0.32 with it?

@szaimen
Copy link
Contributor

szaimen commented Mar 20, 2023

Sorry, I don't have the permissions to create a new release...

@steevanb
Copy link
Author

@wapmorgan a little ping to create the version? thanks :)

@Axent96
Copy link
Contributor

Axent96 commented Mar 22, 2023

@wapmorgan || @kkmuffme ping for new release tag with last merge into master branch :)

@wapmorgan
Copy link
Owner

Created new version 2.0.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants