Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started port. #1

Open
fire opened this issue Oct 21, 2023 · 8 comments
Open

Started port. #1

fire opened this issue Oct 21, 2023 · 8 comments

Comments

@fire
Copy link

fire commented Oct 21, 2023

https://github.com/V-Sekai/godot/tree/vsk-csg-deform-4.2

Hi I started the port to C++ modules.

@fire
Copy link
Author

fire commented Oct 21, 2023

https://youtu.be/JAVmgFGMM3Q Youtube video.

@fire
Copy link
Author

fire commented Oct 21, 2023

  1. collisions should be generated

@wareya
Copy link
Owner

wareya commented Oct 21, 2023

🎉

@fire
Copy link
Author

fire commented Oct 21, 2023

Do you have any ideas on some of these bugs?

  1. the grid is wrong
  2. deforming locks the plane of movement

@wareya
Copy link
Owner

wareya commented Oct 21, 2023

  1. Try a 9 x 5 x 9 lattice with a plane mesh set to subdivide 15 x 15 times:
    image
    image

  2. Gizmos are ignored as long as "Do Deform" is enabled; this felt better to me at the time, but maybe it should be an "ignore gizmos" button instead (not sure how it would work)

@fire
Copy link
Author

fire commented Oct 22, 2023

I'll try to work on this next weekend. Need to conserve momentum.

@fire
Copy link
Author

fire commented Oct 23, 2023

@wareya Do you know how to modify the algorithm so it works with mesh [add,subtract, and difference]?

Edited:

https://github.com/V-Sekai/godot/blob/vsk-csg-deform-4.2/modules/csg/csg_shape.h#L623-L639

Currently I generate a mesh, but I can move the deform so it operates on the csg combined shape..

@fire
Copy link
Author

fire commented Oct 23, 2023

Todo:

  1. `ERROR: Invalid default value for parameter 'mode' of method 'CSGDeform3D.affect_lattice'.
    at: _generate_cs_method (modules/mono/editor/bindings_generator.cpp:2104)
  2. Generate proper xml documentation. I think a few parameters are missing names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants