Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a11y attributes for to define steps in more accessible way #140

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

AnnaRybkina
Copy link
Contributor

@AnnaRybkina AnnaRybkina commented Oct 23, 2023

Background: https://nmp-jira.atlassian.net/jira/software/projects/WARP/boards/15?label=web&selectedIssue=WARP-329

  • Added role=img and aria-label on the divs that renders the circles (instead of alt text)
  • added list markup to communicate the total number of steps to the screen reader
  • Added aria-current=step to indicate current step
image

@AnnaRybkina AnnaRybkina changed the title fix: add a11y attrbutes for to define steps in more accessible way fix: add a11y attributes for to define steps in more accessible way Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-25 12:42 UTC

@AnnaRybkina AnnaRybkina marked this pull request as ready for review October 24, 2023 14:22
@AnnaRybkina AnnaRybkina requested a review from a team October 25, 2023 10:04
@AnnaRybkina AnnaRybkina merged commit 47af229 into next Oct 25, 2023
5 checks passed
@AnnaRybkina AnnaRybkina deleted the step-a11y branch October 25, 2023 12:41
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
## [1.1.2-next.4](v1.1.2-next.3...v1.1.2-next.4) (2023-10-25)

### Bug Fixes

* add a11y attributes for to define steps in more accessible way ([#140](#140)) ([47af229](47af229))
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
# [1.2.0](v1.1.1...v1.2.0) (2023-11-06)

### Bug Fixes

* a11y adjust attention ([#127](#127)) ([6fba30c](6fba30c))
* a11y fixes for select component ([#146](#146)) ([d4d8c18](d4d8c18))
* a11y issues for expandable ([#138](#138)) ([ff8fecc](ff8fecc))
* activate translations in steps ([#144](#144)) ([8eb603e](8eb603e))
* add a11y attributes for to define steps in more accessible way ([#140](#140)) ([47af229](47af229))
* Add role property to Box component ([#139](#139)) ([e46db48](e46db48))
* adjust further a11y issues attention ([#147](#147)) ([b668aeb](b668aeb))
* crowdin build step ([#142](#142)) ([f2ace37](f2ace37))

### Features

* **attention:** add close button ([#149](#149)) ([6a5c9d6](6a5c9d6))
* **attention:** add highlight variant ([#145](#145)) ([1b86124](1b86124))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants