fix: crowdin build step #142
Conversation
| #. Aria label for magnifying glass used as affix in Combobox and Textfield components | ||
| #. js-lingui-explicit-id | ||
| #: packages/_helpers/affix.tsx:37 | ||
| #~ msgid "forms.affix.aria.magnifyingGlass" | ||
| #~ msgstr "Suurennuslasi" |
There was a problem hiding this comment.
I don't know if that could be the reason, but it looks like the clean script removes whatever is using #~. I wonder if making the two last lines the same as in other .po files, so without the #~, would solve the issue. Otherwise I don't understand how the translations can work if we remove these lines completely 😅
There was a problem hiding this comment.
but the .po files are automatically generated by running lingui extract so how should we manually change how they are being generated? :)
There was a problem hiding this comment.
I don't understand how it works that some files have #~ before msgid and some don't while running lingui extract (it felt like the missing --strict option in that command had something to do with it). I merely noticed that it seemed those #~ characters might be the reason that the crowdin sync job failed. But we should be able to check it by merging this PR I guess 🙂
There was a problem hiding this comment.
Yes I'm hoping that this solves the crowdin sync job failure, since this is the solution that Christoffer suggested to implement to fix the build. So hopefully it should work! 🙂
|
## [1.1.2-next.3](v1.1.2-next.2...v1.1.2-next.3) (2023-10-24) ### Bug Fixes * crowdin build step ([#142](#142)) ([f2ace37](f2ace37))
# [1.2.0](v1.1.1...v1.2.0) (2023-11-06) ### Bug Fixes * a11y adjust attention ([#127](#127)) ([6fba30c](6fba30c)) * a11y fixes for select component ([#146](#146)) ([d4d8c18](d4d8c18)) * a11y issues for expandable ([#138](#138)) ([ff8fecc](ff8fecc)) * activate translations in steps ([#144](#144)) ([8eb603e](8eb603e)) * add a11y attributes for to define steps in more accessible way ([#140](#140)) ([47af229](47af229)) * Add role property to Box component ([#139](#139)) ([e46db48](e46db48)) * adjust further a11y issues attention ([#147](#147)) ([b668aeb](b668aeb)) * crowdin build step ([#142](#142)) ([f2ace37](f2ace37)) ### Features * **attention:** add close button ([#149](#149)) ([6a5c9d6](6a5c9d6)) * **attention:** add highlight variant ([#145](#145)) ([1b86124](1b86124))
This should fix the failed synchronize-with-crowdin step that is currently on next.
After speaking to Christoffer I found out that there's currently a bug in Crowdin, but that they are working on to fix. In the meanwhile I have the updated ReadMe-file with temporary solution to fix this issue.