Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y fixes for select component #146

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix: a11y fixes for select component #146

merged 3 commits into from
Nov 2, 2023

Conversation

AnnaRybkina
Copy link
Contributor

@AnnaRybkina AnnaRybkina commented Oct 26, 2023

Background: https://nmp-jira.atlassian.net/jira/software/projects/WARP/boards/15?label=web&selectedIssue=WARP-334

  • pass disabled prop
  • add valid option to the select with invalid options

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-02 14:38 UTC

@AnnaRybkina AnnaRybkina changed the title Select a11y fix: a11y fixes for select component Oct 27, 2023
@AnnaRybkina AnnaRybkina marked this pull request as ready for review October 27, 2023 13:56
@AnnaRybkina AnnaRybkina requested a review from a team October 27, 2023 13:56
Copy link
Contributor

@BalbinaK BalbinaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@felicia-haggqvist felicia-haggqvist merged commit d4d8c18 into next Nov 2, 2023
3 checks passed
@felicia-haggqvist felicia-haggqvist deleted the select-a11y branch November 2, 2023 14:37
github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
# [1.2.0-next.4](v1.2.0-next.3...v1.2.0-next.4) (2023-11-02)

### Bug Fixes

* a11y fixes for select component ([#146](#146)) ([d4d8c18](d4d8c18))
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
# [1.2.0](v1.1.1...v1.2.0) (2023-11-06)

### Bug Fixes

* a11y adjust attention ([#127](#127)) ([6fba30c](6fba30c))
* a11y fixes for select component ([#146](#146)) ([d4d8c18](d4d8c18))
* a11y issues for expandable ([#138](#138)) ([ff8fecc](ff8fecc))
* activate translations in steps ([#144](#144)) ([8eb603e](8eb603e))
* add a11y attributes for to define steps in more accessible way ([#140](#140)) ([47af229](47af229))
* Add role property to Box component ([#139](#139)) ([e46db48](e46db48))
* adjust further a11y issues attention ([#147](#147)) ([b668aeb](b668aeb))
* crowdin build step ([#142](#142)) ([f2ace37](f2ace37))

### Features

* **attention:** add close button ([#149](#149)) ([6a5c9d6](6a5c9d6))
* **attention:** add highlight variant ([#145](#145)) ([1b86124](1b86124))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants