Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): don't open on modifier key press and fix aria-expanded #152

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Nov 8, 2023

Fixes WARP-333

  • notify assistive technologies when the combobox is expanded
  • don't open the list of options when a modifier key is pressed

@BalbinaK BalbinaK requested a review from a team November 8, 2023 13:41
Copy link
Contributor

github-actions bot commented Nov 8, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-08 14:05 UTC

@BalbinaK BalbinaK merged commit 71e42f6 into next Nov 8, 2023
3 checks passed
@BalbinaK BalbinaK deleted the fix/a11y-combobox branch November 8, 2023 14:04
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
## [1.2.1-next.1](v1.2.0...v1.2.1-next.1) (2023-11-08)

### Bug Fixes

* **combobox:** don't open on modifier key press and fix aria-expanded ([#152](#152)) ([71e42f6](71e42f6))
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
## [1.2.1](v1.2.0...v1.2.1) (2023-11-29)

### Bug Fixes

* **combobox:** don't open on modifier key press and fix aria-expanded ([#152](#152)) ([71e42f6](71e42f6))
* Import icons in the correct way ([#169](#169)) ([f279db9](f279db9))
* **textfield:** allow styling input's left padding when prefix is wider than 40px ([#173](#173)) ([89e5a27](89e5a27))
* **textfield:** render prefix before input ([#161](#161)) ([2017cff](2017cff))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants