feat: Add more features on how attention component is positioned #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from floatingUI from the core-repo
…rowDirection to get updated placement returned from floating-ui
…es warning in console
… mounted or isShowing is false
…over and pover with icon as target el examples
…or getVariant + useAutoUpdatePosition
BalbinaK
reviewed
Apr 9, 2024
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
# [1.5.0-next.1](v1.4.5-next.1...v1.5.0-next.1) (2024-04-16) ### Features * Add more features on how attention component is positioned ([#215](#215)) ([5bf7883](5bf7883))
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2024
# [1.5.0](v1.4.4...v1.5.0) (2024-05-15) ### Bug Fixes * Styling fixes for Card component ([#229](#229)) ([a99dc9c](a99dc9c)) * **textfield/textarea:** clean up classes ([#239](#239)) ([4372285](4372285)) ### Features * Add an optional prop to enable nofollow for pagination component ([#231](#231)) ([9534ae3](9534ae3)) * Add more features on how attention component is positioned ([#215](#215)) ([5bf7883](5bf7883)) * add more functionality to attention component ([#233](#233)) ([95c20b3](95c20b3)) * Individual imports ([#212](#212)) ([766282c](766282c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixes for Jira-tickets: WARP-432, WARP-341 & WARP-373
distance,skidding,flip,fallbackPlacementsprops to Attention componentpointingAtDirectionto also account for the new placements:top-start,top-end,right-start,right-end,left-start,left-end,bottom-start,bottom-endarrowDirectionClassnameto also handle when placement includes either-startor-enduseEffectto handle when to callautoUpdatePositionthat will add event-listeners for on scroll and on resize and callsrecompute. Whencleanupis returned, the event-listeners will be removed.warp-ds/corerepo.Attention.stories.tsxto also show howdistance,skidding,flip,fallbackPlacementsand the new placements can be used.AttentionTest.tsxand add tests for Attention componentAttention.tsas a helper file for Attention component@warp-ds/coreto use latest changes