Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dead-toggle): add 'name' prop #223

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(dead-toggle): add 'name' prop #223

merged 2 commits into from
Mar 14, 2024

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Mar 8, 2024

Description

Fixes WARP-514

Fixes behaviour of a checked DeadToggle of type radio when multiple groups of DeadToggles are rendered on the same page.

Before After
Screenshot of 2 groups of cards with radio dead-toggles, both groups have 1 selected card, but in the first group the radio element is not checked   Screenshot of 2 groups of cards with radio dead-toggles, both groups have 1 selected card, and both radio elements are checked

BalbinaK added 2 commits March 8, 2024 11:59
@BalbinaK
fix(dead-toggle): add 'name' prop
a8e4ad7 
Fix behaviour of DeadToggle radio checked value when multiple groups of DeadToggles are rendered
@BalbinaK
chore(deps): update @warp-ds/css to 1.8.5
242b861
@BalbinaK BalbinaK requested a review from a team March 8, 2024 11:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-14 10:19 UTC

felicia-haggqvist
felicia-haggqvist approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) Nice job! 🎉

@BalbinaK BalbinaK merged commit 2ff3ad7 into next Mar 14, 2024
3 checks passed
@BalbinaK BalbinaK deleted the fix/multiple-dead-toggle-groups branch March 14, 2024 10:18
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
@semantic-release-bot
chore(release): 1.4.4-next.1 [skip ci]
00210dd 
## [1.4.4-next.1](v1.4.3...v1.4.4-next.1) (2024-03-14)

### Bug Fixes

* **dead-toggle:** add 'name' prop ([#223](#223)) ([2ff3ad7](2ff3ad7))
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@semantic-release-bot
chore(release): 1.4.4 [skip ci]
fe045da 
## [1.4.4](v1.4.3...v1.4.4) (2024-03-21)

### Bug Fixes

* **dead-toggle:** add 'name' prop ([#223](#223)) ([2ff3ad7](2ff3ad7))
* **forms:** use correct colors in label and error text ([#225](#225)) ([ac5396b](ac5396b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicia-haggqvist felicia-haggqvist felicia-haggqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BalbinaK @felicia-haggqvist