Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add component classes to the combobox #38

Merged
merged 2 commits into from
May 25, 2023
Merged

feat: add component classes to the combobox #38

merged 2 commits into from
May 25, 2023

Conversation

AnnaRybkina
Copy link
Contributor

CarolineGard
CarolineGard approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@CarolineGard CarolineGard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works well

@AnnaRybkina AnnaRybkina merged commit 232bf60 into alpha May 25, 2023
@AnnaRybkina AnnaRybkina deleted the combobox branch May 25, 2023 14:50
github-actions bot pushed a commit that referenced this pull request May 25, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
d8a7263 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-05-25)

### Bug Fixes

* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
github-actions bot pushed a commit that referenced this pull request May 26, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
108e32e 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-05-26)

### Bug Fixes

* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
github-actions bot pushed a commit that referenced this pull request May 29, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
4070fc8 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-05-29)

### Bug Fixes

* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
github-actions bot pushed a commit that referenced this pull request May 30, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
6d8e03c 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-05-30)

### Bug Fixes

* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* Move react specific switch track classes to component-classes ([#40](#40)) ([a024fb5](a024fb5))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
b86518b 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-06-01)

### Bug Fixes

* **alert:** use imported instead of inline classes ([#41](#41)) ([c8c8da2](c8c8da2))
* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* Move react specific switch track classes to component-classes ([#40](#40)) ([a024fb5](a024fb5))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
4940959 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-06-01)

### Bug Fixes

* **alert:** use imported instead of inline classes ([#41](#41)) ([c8c8da2](c8c8da2))
* **changelog:** remove repeated changes ([#42](#42)) ([41b4d98](41b4d98))
* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* Move react specific switch track classes to component-classes ([#40](#40)) ([a024fb5](a024fb5))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.25 [skip ci]
37f4ace 
# [1.0.0-alpha.25](v1.0.0-alpha.24...v1.0.0-alpha.25) (2023-06-01)

### Bug Fixes

* **alert:** use imported instead of inline classes ([#41](#41)) ([c8c8da2](c8c8da2))
* **changelog:** remove repeated changes ([#42](#42)) ([41b4d98](41b4d98))
* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* Move react specific switch track classes to component-classes ([#40](#40)) ([a024fb5](a024fb5))
* **releases:** trigger release of 1.0.0-alpha.25 ([d99c1f4](d99c1f4))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
bdc9705 
# 1.0.0 (2023-08-30)

### Bug Fixes

* add common css ([37b6d7e](37b6d7e))
* add component classes to Breadcrumbs ([#23](#23)) ([9818cba](9818cba))
* add component classes to select ([#21](#21)) ([8a7632c](8a7632c))
* add Finnish language ([77a32c0](77a32c0))
* add fix for button ([f4527d4](f4527d4))
* add missing classes to textarea and refactor ([#20](#20)) ([4116c3f](4116c3f))
* add more translations ([a8f57a6](a8f57a6))
* add placeholder to texarea ([cebd307](cebd307))
* add translation for "magnifying glass" used in affix ([41d6774](41d6774))
* add type module ([c96d22c](c96d22c))
* Add Warp component-classes to the box component ([#19](#19)) ([e172165](e172165))
* Add Warp component-classes to the Pill component ([#28](#28)) ([0db49ac](0db49ac))
* **alert:** don't use dynamic classes ([#8](#8)) ([85a136d](85a136d))
* **alert:** use imported instead of inline classes ([#41](#41)) ([c8c8da2](c8c8da2))
* **alert:** use negative and positive variants instead of critical and success ([#9](#9)) ([82aa7ec](82aa7ec))
* apply new tokens to textfield and textarea ([#16](#16)) ([59b3ec8](59b3ec8))
* build storybook with vite instead of webpack ([#44](#44)) ([f569d2a](f569d2a))
* bump @warp-ds/css package to get fix for select chevron component class ([0cb53a2](0cb53a2))
* bump component classes ([#46](#46)) ([8e33518](8e33518))
* bump packages ([#43](#43)) ([5e064e7](5e064e7))
* bump versions ([#47](#47)) ([a347969](a347969))
* **buttons:** bump component-classes to 1.0.0-alpha.116 ([#60](#60)) ([b483bcd](b483bcd))
* **card:** apply component classes to card component ([#33](#33)) ([a0937a8](a0937a8))
* **changelog:** remove repeated changes ([#42](#42)) ([41b4d98](41b4d98))
* classes for toggle ([#26](#26)) ([65211a7](65211a7))
* **components:** update component classes ([#49](#49)) ([7a445d2](7a445d2))
* detect locale on server ([1ffbc50](1ffbc50))
* **expandable:** bump component classes package ([f508125](f508125))
* **expandable:** change single quote to quote ([1a8816e](1a8816e))
* **expandable:** merge alpha with branch ([78a9236](78a9236))
* export button, and input components ([#18](#18)) ([3cc5894](3cc5894))
* extract supportedLocales to avoid to define it twice ([73a81f6](73a81f6))
* fix broken docs after vite upgrade ([#29](#29)) ([6f65554](6f65554))
* import and load messages in component to avoid issues with dynamic import ([4aeadf0](4aeadf0))
* **index.ts:** export expandable, box and select from packages/index.ts ([#30](#30)) ([7b1e21c](7b1e21c))
* make sure to style text for links as buttons ([#35](#35)) ([96aa46c](96aa46c))
* Move react specific switch track classes to component-classes ([#40](#40)) ([a024fb5](a024fb5))
* only support 'en' and 'nb' for now ([3e78b12](3e78b12))
* **packages:** use className and style in TextField and Select ([#50](#50)) ([fdfe96a](fdfe96a))
* radio buttons classes ([#31](#31)) ([3a5ca84](3a5ca84))
* **releases:** trigger release of 1.0.0-alpha.25 ([d99c1f4](d99c1f4))
* remove background from checkbox/toggle ([#51](#51)) ([f0eba8e](f0eba8e))
* remove common.css and use safelist ([#14](#14)) ([60c6607](60c6607))
* secondary button prop is not true by default ([#56](#56)) ([d82680a](d82680a))
* stable FINN prod alpha-release ([#59](#59)) ([0733c47](0733c47))
* **step:** hide outer lines on horizontal variant of steps ([#62](#62)) ([a345319](a345319))
* **stepsindicator:** update version of @warp-ds/component-classes ([09d9022](09d9022))
* Styling alert component with tokens ([#5](#5)) ([9748c5f](9748c5f))
* trigger release of 1.0.0-alpha.38 ([a275d63](a275d63))
* upgrade storybook ([#27](#27)) ([d0ba4b1](d0ba4b1))
* use correct padding for small buttons ([a054d29](a054d29))
* use css packages instead of component-classes ([#55](#55)) ([64d45d3](64d45d3))
* use process.env.NMP_LANGUAGE if available if SSR ([a7bba9c](a7bba9c))
* use updated component-classes in alert component ([#15](#15)) ([b4c1b9a](b4c1b9a))
* warpify modal ([#36](#36)) ([5d0b084](5d0b084))

### Features

* add button styling ([#7](#7)) ([bf2e9e1](bf2e9e1))
* add component classes to the combobox ([#38](#38)) ([232bf60](232bf60))
* add internationalization ([4ffec64](4ffec64))
* **attention:** warpify attention ([#37](#37)) ([61f6895](61f6895))
* **expandable:** add warp component classes to expandable ([581ecdf](581ecdf))
* **expandable:** bump warp versions containing new tokens and component classes ([21c9074](21c9074))
* **stepindicator:** add component classes for stepindicator ([6de4822](6de4822))
* **tabs:** warpify tabs ([#34](#34)) ([ce210d2](ce210d2))
* Warpified Switch component ([#39](#39)) ([20eddea](20eddea))
* **workflows:** add eik aliasing script to realease.yml ([#17](#17)) ([ce4604a](ce4604a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarolineGard CarolineGard CarolineGard approved these changes

@Skadefryd Skadefryd Awaiting requested review from Skadefryd

@magnuh magnuh Awaiting requested review from magnuh

@BalbinaK BalbinaK Awaiting requested review from BalbinaK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaRybkina @CarolineGard