bugfix: scrolls to top of table on any key press if the top is not on…

… the screen (#348)
handsontable · Feb 25, 2013 · 290cde9 · 290cde9
1 parent f2b412f
commit 290cde9
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 16 deletions.
diff --git a/dist/jquery.handsontable.full.css b/dist/jquery.handsontable.full.css
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Mon Feb 25 2013 20:14:15 GMT+0100 (Central European Standard Time)
+ * Date: Mon Feb 25 2013 20:22:36 GMT+0100 (Central European Standard Time)
  */
 
 .handsontable {

diff --git a/dist/jquery.handsontable.full.js b/dist/jquery.handsontable.full.js
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Mon Feb 25 2013 20:14:15 GMT+0100 (Central European Standard Time)
+ * Date: Mon Feb 25 2013 20:22:36 GMT+0100 (Central European Standard Time)
  */
 /*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */
 
@@ -2778,19 +2778,16 @@ HandsontableTextEditorClass.prototype.beginEditing = function (row, col, prop, u
 
   this.instance.rootElement.append(this.TEXTAREA_PARENT);
 
+  this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
   this.TEXTAREA[0].focus();
   this.setCaretPosition(this.TEXTAREA[0], this.TEXTAREA[0].value.length);
 
   if (this.instance.getSettings().asyncRendering) {
-    this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
     var that = this;
     setTimeout(function () {
       that.refreshDimensions(row, col); //need it after rerender to reposition in case scroll was moved
     }, 0);
   }
-  else {
-    this.refreshDimensions(row, col);
-  }
 }
 
 HandsontableTextEditorClass.prototype.refreshDimensions = function (row, col) {

diff --git a/jquery.handsontable.css b/jquery.handsontable.css
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Mon Feb 25 2013 20:14:15 GMT+0100 (Central European Standard Time)
+ * Date: Mon Feb 25 2013 20:22:36 GMT+0100 (Central European Standard Time)
  */
 
 .handsontable {

diff --git a/jquery.handsontable.js b/jquery.handsontable.js
@@ -6,7 +6,7 @@
  * Licensed under the MIT license.
  * http://handsontable.com/
  *
- * Date: Mon Feb 25 2013 20:14:15 GMT+0100 (Central European Standard Time)
+ * Date: Mon Feb 25 2013 20:22:36 GMT+0100 (Central European Standard Time)
  */
 /*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */
 
@@ -2778,19 +2778,16 @@ HandsontableTextEditorClass.prototype.beginEditing = function (row, col, prop, u
 
   this.instance.rootElement.append(this.TEXTAREA_PARENT);
 
+  this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
   this.TEXTAREA[0].focus();
   this.setCaretPosition(this.TEXTAREA[0], this.TEXTAREA[0].value.length);
 
   if (this.instance.getSettings().asyncRendering) {
-    this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
     var that = this;
     setTimeout(function () {
       that.refreshDimensions(row, col); //need it after rerender to reposition in case scroll was moved
     }, 0);
   }
-  else {
-    this.refreshDimensions(row, col);
-  }
 }
 
 HandsontableTextEditorClass.prototype.refreshDimensions = function (row, col) {

diff --git a/src/editors/textEditor.js b/src/editors/textEditor.js
@@ -182,19 +182,16 @@ HandsontableTextEditorClass.prototype.beginEditing = function (row, col, prop, u
 
   this.instance.rootElement.append(this.TEXTAREA_PARENT);
 
+  this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
   this.TEXTAREA[0].focus();
   this.setCaretPosition(this.TEXTAREA[0], this.TEXTAREA[0].value.length);
 
   if (this.instance.getSettings().asyncRendering) {
-    this.refreshDimensions(row, col); //need it instantly, to prevent https://github.com/warpech/jquery-handsontable/issues/348
     var that = this;
     setTimeout(function () {
       that.refreshDimensions(row, col); //need it after rerender to reposition in case scroll was moved
     }, 0);
   }
-  else {
-    this.refreshDimensions(row, col);
-  }
 }
 
 HandsontableTextEditorClass.prototype.refreshDimensions = function (row, col) {