Skip to content

Commit

Permalink
bugfix: inline cell styles applied by cell renderer were not removed …
Browse files Browse the repository at this point in the history
…on table scroll (#353, #376)
  • Loading branch information
warpech committed Mar 7, 2013
1 parent a7f740c commit a9b328d
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## HEAD

Bugfix:
- inline cell styles applied by cell renderer were not removed on table scroll ([#353](https://github.com/warpech/jquery-handsontable/issues/353), [#376](https://github.com/warpech/jquery-handsontable/issues/376))

Docs:
- simplify CSS for demo pages (get rid of `bottomSpace` classes)
- refresh the style of jsFiddle links
Expand Down
2 changes: 1 addition & 1 deletion dist/jquery.handsontable.full.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Licensed under the MIT license.
* http://handsontable.com/
*
* Date: Thu Mar 07 2013 00:06:10 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:10:44 GMT+0100 (Central European Standard Time)
*/

.handsontable {
Expand Down
5 changes: 3 additions & 2 deletions dist/jquery.handsontable.full.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Licensed under the MIT license.
* http://handsontable.com/
*
* Date: Thu Mar 07 2013 00:06:10 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:10:44 GMT+0100 (Central European Standard Time)
*/
/*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */

Expand Down Expand Up @@ -4356,7 +4356,7 @@ Handsontable.PluginHooks.push('afterGetColWidth', htManualColumnResize.getColWid
/**
* walkontable 0.2.0
*
* Date: Thu Feb 28 2013 17:54:27 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:08:43 GMT+0100 (Central European Standard Time)
*/

function WalkontableBorder(instance, settings) {
Expand Down Expand Up @@ -6177,6 +6177,7 @@ WalkontableTable.prototype._doDraw = function () {
else {
TD = TR.childNodes[c + frozenColumnsCount];
TD.className = '';
TD.removeAttribute('style');
this.instance.getSetting('cellRenderer', offsetRow + r, offsetColumn + c, TD);
if (this.hasEmptyCellProblem && TD.innerHTML === '') { //IE7
TD.innerHTML = ' ';
Expand Down
2 changes: 1 addition & 1 deletion jquery.handsontable.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Licensed under the MIT license.
* http://handsontable.com/
*
* Date: Thu Mar 07 2013 00:06:10 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:10:44 GMT+0100 (Central European Standard Time)
*/

.handsontable {
Expand Down
5 changes: 3 additions & 2 deletions jquery.handsontable.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Licensed under the MIT license.
* http://handsontable.com/
*
* Date: Thu Mar 07 2013 00:06:10 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:10:44 GMT+0100 (Central European Standard Time)
*/
/*jslint white: true, browser: true, plusplus: true, indent: 4, maxerr: 50 */

Expand Down Expand Up @@ -4356,7 +4356,7 @@ Handsontable.PluginHooks.push('afterGetColWidth', htManualColumnResize.getColWid
/**
* walkontable 0.2.0
*
* Date: Thu Feb 28 2013 17:54:27 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:08:43 GMT+0100 (Central European Standard Time)
*/

function WalkontableBorder(instance, settings) {
Expand Down Expand Up @@ -6177,6 +6177,7 @@ WalkontableTable.prototype._doDraw = function () {
else {
TD = TR.childNodes[c + frozenColumnsCount];
TD.className = '';
TD.removeAttribute('style');
this.instance.getSetting('cellRenderer', offsetRow + r, offsetColumn + c, TD);
if (this.hasEmptyCellProblem && TD.innerHTML === '') { //IE7
TD.innerHTML = ' ';
Expand Down
3 changes: 2 additions & 1 deletion src/3rdparty/walkontable.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* walkontable 0.2.0
*
* Date: Thu Feb 28 2013 17:54:27 GMT+0100 (Central European Standard Time)
* Date: Thu Mar 07 2013 10:08:43 GMT+0100 (Central European Standard Time)
*/

function WalkontableBorder(instance, settings) {
Expand Down Expand Up @@ -1822,6 +1822,7 @@ WalkontableTable.prototype._doDraw = function () {
else {
TD = TR.childNodes[c + frozenColumnsCount];
TD.className = '';
TD.removeAttribute('style');
this.instance.getSetting('cellRenderer', offsetRow + r, offsetColumn + c, TD);
if (this.hasEmptyCellProblem && TD.innerHTML === '') { //IE7
TD.innerHTML = ' ';
Expand Down

0 comments on commit a9b328d

Please sign in to comment.