Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column sort invoked after second cell edit #1020

Closed
mariotacke opened this issue Sep 2, 2013 · 4 comments
Closed

Column sort invoked after second cell edit #1020

mariotacke opened this issue Sep 2, 2013 · 4 comments
Labels

Comments

@mariotacke
Copy link

Hello,

Please see attached fiddle. When you create a second HOT in the afterChange callback, the first HOT's column sorting is invoked again (after a second edit).

Steps to reproduce bug:
#1: Start fiddle
#2: Sort Column B (ascending or descending, does not matter)
#3: Enter any number in any cell, press enter.
#4: Enter any number in cell below last entered cell, press enter

Problem:
The handsontable applies column sorting again even though it was
not specifically invoked!

Fiddle: http://jsfiddle.net/jaEAu/

@psmolenski
Copy link
Contributor

I agree that it behaves strangely, but I am not sure if this bug is related to columnSort plugin. It seems like it has something to do with redefining data and columns parameters on each createTotal() invocation. Until we investigate this issue you can use jsFiddle that I've prepared. It does exactly the same thing as yours (computing total sum) but using a different technique.
http://jsfiddle.net/VDzXH/

psmolenski added a commit that referenced this issue Sep 3, 2013
…f them have sorting enabled and others not.
@psmolenski
Copy link
Contributor

The problem was indeed lying in columnSorting plugin. I've managed to fix it. My changes will be released in version 0.9.17. Thanks for reporting it.

@mariotacke
Copy link
Author

Thanks for actively watching the community! Great work 👍

@ghost ghost assigned psmolenski Sep 4, 2013
psmolenski referenced this issue Sep 5, 2013
Conflicts:
	test/jasmine/spec/plugins/columnSortingSpec.js
@psmolenski
Copy link
Contributor

Fixed in version 0.9.17. Please, upgrade and confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants