Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadData: Reload Table with different row count fails #1050

Closed
sapreuss opened this issue Sep 19, 2013 · 4 comments
Closed

loadData: Reload Table with different row count fails #1050

sapreuss opened this issue Sep 19, 2013 · 4 comments

Comments

@sapreuss
Copy link

Hi,

I'm using handsontable with a feature to change the number of displayed rows.
The user may change the amount and the table data will be reloaded - without creating a new table just using the 'loadData' method. The feature worked fine up to now.

Today I updated to release 0.9.18 and my feature fails.

I spotted the cause in 'this.translateRow' method trying to read a non existent 'instance.sortIndex[row]'. This happens, when the row number exceeds the row number of the original table.

Feature or Bug?

@psmolenski
Copy link
Contributor

Could you prepare a jsFiddle?

@sapreuss
Copy link
Author

sapreuss commented Oct 2, 2013

Hi I am on vac this week. 
Will prepare one next week.

Seb. Preuß mobil

-------- Ursprüngliche Nachricht --------
Von: psmolenski notifications@github.com
Datum: 01.10.2013 9:56 (GMT+01:00)
An: warpech/jquery-handsontable jquery-handsontable@noreply.github.com
Cc: sapreuss sapreuss@input98.de
Betreff: Re: [jquery-handsontable] loadData: Reload Table with different row count fails (#1050)

Could you prepare a jsFiddle?


Reply to this email directly or view it on GitHub.

@sapreuss
Copy link
Author

sapreuss commented Oct 7, 2013

Hi,

as I promised, here is the fiddle: http://jsfiddle.net/sapreuss/33XFt/4/

After the start, 100 Rows, everything fine.
Press the reload button, 200 rows, everything fine.

Restart, 100 rows.
Press the column header e.g. column 'E'
Press the reload button - error

Thx

@AMBudnik
Copy link
Contributor

@sapreuss I tried to reproduce it - but works fine In my opinion. In reloads the same with and without pressing any column header. Since in an issue from 2013 I assume it can be closed if it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants