Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete and empty value #254

Closed
ronnyah opened this issue Nov 23, 2012 · 11 comments
Closed

Autocomplete and empty value #254

ronnyah opened this issue Nov 23, 2012 · 11 comments
Assignees
Labels

Comments

@ronnyah
Copy link

ronnyah commented Nov 23, 2012

Hi,

One of the values I need for the "autocomplete" is an empty value (don't ask...). This worked in previous versions but seem to break the function in the latest master. Is this intentionally and I have to code my way around or is this a bug of some sorts?

@dawidr
Copy link

dawidr commented Nov 25, 2012

I also noticed that. Empty value would be nice.
But there is workaround for that - use you backspace key to delete value and then confirm it with return key. You will have empty value.

@ronnyah
Copy link
Author

ronnyah commented Nov 25, 2012

Ah, nice tip. Thank you :)

@warpech
Copy link
Member

warpech commented Nov 26, 2012

Is it really broken since last update? I think it is still working in the "lazy" mode but indeed does not work in the "strict" mode (http://handsontable.com/demo/autocomplete.html)

Another tip is to use Delete key on the cell instead of editing it. Works in lazy and strict mode.

Would you need it in the strict mode? I am looking for some consistent way to define it...

@dawidr
Copy link

dawidr commented Nov 26, 2012

You are right, I'm using strict mode. Since I found workaround with Delete key I got what I need.
But empty value would be usefull in strict mode.

@ronnyah
Copy link
Author

ronnyah commented Nov 26, 2012

It used to work, but did not work after trying to update. I have been messing around a little so I am not entirely sure it was broken between the previous and this update though... Anyways, I use strict mode, but I could just code my way around it and use lazy mode instead :) No worries, I see that having an empty value as a "autocomplete" function is odd ;)

@warpech
Copy link
Member

warpech commented Mar 18, 2013

I created a fiddle to help test the problem: http://jsfiddle.net/NuSLc/

Current status is same as commented by dawidr: it works when you press Delete on a strict field that allows empty value. But the empty value does not show on the list.

A fix is on its way :)

@ronnyah
Copy link
Author

ronnyah commented Mar 22, 2013

Thank you! I feel that this might a bit far fetched example and sort of weird in its nature. It also is no problem to code around it for me, so no particular need to prioritize the fix on my part. Have a nice weekend!

@warpech
Copy link
Member

warpech commented Mar 26, 2013

This issue should now be fixed in Handsontable 0.8.16.

Bootstrap Typeahead does not allow empty strings as a value, but we managed to workaround it. Can you please upgrade and test if it works for you?

@warpech warpech closed this as completed Mar 26, 2013
@dansabirov
Copy link

Hi, folks, please take a part in discuss of my question #526, because it is crossed with this problem too

@warpech
Copy link
Member

warpech commented Mar 26, 2013

Actually, after my change 7389c8e it is possible to use empty string as a value but then text "[empty string]" is visible in options list... Not good :)

@warpech warpech reopened this Mar 26, 2013
@ghost ghost assigned warpech Mar 26, 2013
warpech added a commit that referenced this issue Mar 31, 2013
@warpech
Copy link
Member

warpech commented Mar 31, 2013

The above issue ("[empty string]" label in dropdown) is now fixed in 0.8.17

@warpech warpech closed this as completed Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants