Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getColHeaders throws exception #569

Closed
provegard opened this issue Apr 15, 2013 · 2 comments
Closed

getColHeaders throws exception #569

provegard opened this issue Apr 15, 2013 · 2 comments
Labels
bug
Milestone
getColHeader fixes

Comments

@provegard
Copy link

I have colHeaders set to true, and call handsontable("getColHeaders"). The result is an exception:

TypeError: Cannot read property 'firstChild' of undefined
    at HTMLDivElement.Handsontable.Core.getColHeader (file:///.../jquery.handsontable-0.8.19.js:1985:14)
    at HTMLDivElement.$.fn.handsontable (file:///.../jquery.handsontable-0.8.19.js:2325:35)

I don't pass anything for the TH parameter of getColHeader, and according to the documentation I shouldn't have to.

This worked in 0.7.5, but doesn't in 0.8.19.
@warpech
Copy link
Member

warpech commented Apr 15, 2013

Duplicate of #382, please don't close. I will fix it for next version

warpech added a commit that referenced this issue Apr 16, 2013
@warpech
bugfix: getColHeaders returns NaN when no argument given - should ret…
1c52416 
…urn array of all column headers (#569, #382); refactor row and column header DOM operations to be consistently defined in `tableView.js`
@warpech
Copy link
Member

warpech commented Apr 19, 2013

This is now fixed in 0.8.20. Thanks for your support @provegard !

@warpech warpech closed this as completed Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
getColHeader fixes
Development

No branches or pull requests
2 participants
@warpech @provegard