Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't directly type values to all cells 0.9.11 while holding SHIFT key #944

Closed
douxlagithub opened this issue Aug 2, 2013 · 15 comments
Closed
Labels

Comments

@douxlagithub
Copy link

I Experience a small but annoying problem when typing non numeric values to HT cells.

Reproduce:
. When I type for example "a" directly to the cell, HT cells are became freezing. It gets normal after double click to the cell. Entering numeric values no problem.

Help for this!

@psmolenski
Copy link
Contributor

I have tried to reproduce the described error using the table at http://handsontable.com/ but everything seems to work fine. Could you prepare a jsFiddle?

@claw68
Copy link

claw68 commented Aug 2, 2013

I basically have same problem with Entering values with the combination of Shift key [Shift+A]

@douxlagithub
Copy link
Author

Actually I have the same problem with @claw68. At first I think the problem is occuring when typing non numeric, but after some try I finally know the exact problem. Thanks claw.

@psmolenski
Copy link
Contributor

Please, prepare an exmaple reproducing the described error, becasue I'm still unable to repeat it.

@claw68
Copy link

claw68 commented Aug 5, 2013

Step 1: go to http://handsontable.com/
Step 2: click on a cell
Step 3: Hold Shift + Any Key [it wont input anything]

Without the combination of Shift, it works normally.

@psmolenski
Copy link
Contributor

Ok, now I get it. The SHIFT + * combinations don't open cell editors. I was trying to type SHIFT + * chars after opening the editor using double click.

@douxlagithub
Copy link
Author

SHIFT + Printable Characters in [0.9.12] stil doesn't work. For me this should be marked as high priority!!

@henderjr
Copy link

henderjr commented Aug 7, 2013

Read the last comment on issue #950 . Will be fixed in release 0.9.13

jasoncrawford pushed a commit to jasoncrawford/jquery-handsontable that referenced this issue Aug 13, 2013
@Glutexo
Copy link

Glutexo commented Aug 13, 2013

After applying the patch by psmolenski, the table behaves correctly in Chrome. In Firefox, it works only for letters not preceded by dead keys.
I mean: If I hold Shift and press S, everything is OK, the editting mode starts and the capital S is inserted.
On the other hand: If I hold Shift and press a dead-key that shall make the next letter to have a caron (ˇ) and then (still holding Shift) I press S, there should be the editting mode started with a letter Š inside the cell. But in fact, the original bug happens and the cell becomes freezed.

@douxlagithub
Copy link
Author

I applied that patch also. But HOT behaves exactly like @Glutexo said. I mainly use HOT just to run in firefox because of my app's specific functionality.

@psmolenski
Copy link
Contributor

I have made some further improvements. Please, check if it solves the described problem.

@jackal-scratch
Copy link

I have checked that on 0.9.12 this bug still exists in Chrome.

@douxlagithub
Copy link
Author

@warpech
Copy link
Member

warpech commented Aug 15, 2013

Fixed in HOT 0.9.13. Could you please get the new version and recheck?

Thanks a lot to everyone involved in investigating this!

@warpech warpech closed this as completed Aug 15, 2013
@douxlagithub
Copy link
Author

It works perfectly. Thanks for the great project. Please pattiently take a look at issue #975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants